Skip to content

fix(nav3): [Part 5] Reject ambiguous argument map keys - #6701

Draft
0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-4from
feat/nav3-serial-name-mappers-5
Draft

0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-4from
feat/nav3-serial-name-mappers-5

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

⚠️ DO NOT REVIEW: Duplicates #6714. I'll remove this PR and rebase the stack once #6714 has been merged.

PR Stack (Nav3 Serial Name Mappers)


📜 Description

When distinct argument map keys become the same recorded string, Sentry now drops that entry’s arguments and records duplicate_key. The destination name is preserved, and a collision by itself does not discard other back stack entries’ arguments.

💡 Motivation and Context

Navigation argument map keys are recorded as strings, so distinct application keys such as 1 and "1" can become indistinguishable in Sentry. Keeping just one value would present an incomplete map as though it were the application’s original data.

addresses: JAVA-787 (link)

💚 How did you test it?

Nav3 release build and all 447 unit tests passed. Repository-wide make format api, Spotless checks, ABI validation, and Detekt passed.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Continue with PR 6: Share bounded argument conversion.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR risk: medium

For commit c1e6945.

Main concerns: data sent to Sentry, reach, host performance.

This label is a hint for reviewers, not an approval.

@github-actions github-actions Bot removed the risk: medium PR risk score: medium label Nov 20, 2026
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 20, 2026
@sentry

sentry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@0xadam-brown 0xadam-brown changed the title fix(nav3): [Nav3 Mappers 5] Reject ambiguous argument map keys fix(nav3): [Part 5] Reject ambiguous argument map keys Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant